Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefreshTokenClient doesnt use client_secret and that causes error in DelegatedTokenClient #625

Closed
ViktorFefilov opened this issue Jul 8, 2019 · 2 comments · Fixed by #632

Comments

@ViktorFefilov
Copy link

flow:

  • get authorization_code
  • initialize DelegatedTokenCredentials with authorization_code
  • do request to resource A with DelegatedTokenCredentials (OK)
  • do request to resource B with DelegatedTokenCredentials (fail with message OAuth2 Authorization code was already redeemed)

But actually bug is not about authorization_code. First exception occurs in RefreshTokenClient in method refreshToken but he just returns null in catch block and by this reason DelegatedTokenCredentials is trying to use authorization_code to acquire access token

my fix for this issue you can find in my fork

@anuchandy
Copy link
Member

linking the fix that @ViktorFefilov mentioned ViktorFefilov@7ec7e79

@jianghaolu
Copy link
Contributor

@ViktorFefilov Thanks for sharing your fix with us. I'm planning to take it in this PR: #632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants