Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required properties rendering incorrect values when the data type has a combined Schema #2056

Closed
AlexRicketts1991 opened this issue Jan 4, 2023 · 7 comments · Fixed by #2060

Comments

@AlexRicketts1991
Copy link

Bug description

I have noticed that there are a number of properties in our api not displaying as required in the Developer Portal.

The open api definition (yml) appears to be correct and if I use the OpenApi Swagger Preview tool in vs code I can see the required properties showing correctly with the red star indicating that they are mandatory.
image

However, when I view this in the developer portal the 'other properties' section all display as not required (note, the properties from the allof schema are showing the required properties correctly).
image

This appears to only be occurring on the data types that are using the 'allof' combined schema but may also be occurring for others as well.

Reproduction steps

  1. Create a yml open api definition with a data type having an 'allof' combined schema and required properties.
  2. Go to the Developer Portal
  3. Scroll down to the newly created data type
  4. See error: Required properties under the Other Properties all display as false.

Expected behavior

Required properties in the Other Properties section should display their values correctly when they have a combined 'allof' schema.

Is your portal managed or self-hosted?

Managed

API Management service name

ig-weu-dev-integration-apim

Environment

Operating system: Windows 10 64 bits
Browser: Edge and Chrome
Version: Edge 103.0.1264.77. Chrome 103.0.5060.134

Many thanks!

@ghost
Copy link

ghost commented Jan 4, 2023

@AlexRicketts1991, thank you for opening this issue. We will triage it within the next few business days.

@i02coroj
Copy link

i02coroj commented Jan 9, 2023

Hi. Getting exactly the same issue as @AlexRicketts1991 .
"Required" working ok for flat objects, but always false when inheriting (meaning using "allOf").

@jsorohova
Copy link
Collaborator

Hello, @AlexRicketts1991 @i02coroj , fixed the issue. It will be rolled out in the next release. Thank you for raising the issue.

@AlexRicketts1991
Copy link
Author

Thanks @jsorohova. I'm still seeing this issue. Has there been another release yet? If not when is it due?

@jsorohova
Copy link
Collaborator

jsorohova commented Feb 16, 2023

Hello @AlexRicketts1991. Yes, it hasn't been deployed to production yet. ETA for now is in 2 weeks. Sorry for inconveniences.

@AlexRicketts1991
Copy link
Author

@jsorohova I'm still seeing this issue, has the fix been released?

@jsorohova
Copy link
Collaborator

Hello @AlexRicketts1991, sorry for the late response, we are currently rolling out a release. If you don't have the changes yet, they should appear within a week or two. Sorry for inconveniences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants