Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

ci: make sure sku is exact match when deciding to create or reuse sku for publishing Windows VHDs #4292

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Feb 23, 2021

Reason for Change:

AKS publishes SKUs starting with aks- and if AKS publishes a SKU first the logic in this script will not create a new non-AKS sku so I'm fixing that.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jsturtevant
Copy link
Contributor

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset marosset force-pushed the win-vhd-publish-sku-exact-match branch from 818d75e to 61c04e5 Compare February 23, 2021 18:52
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #4292 (61c04e5) into master (2e1052a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4292   +/-   ##
=======================================
  Coverage   72.03%   72.03%           
=======================================
  Files         141      141           
  Lines       21633    21633           
=======================================
  Hits        15584    15584           
  Misses       5099     5099           
  Partials      950      950           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e1052a...61c04e5. Read the comment docs.

@marosset marosset merged commit 77f6aa2 into Azure:master Feb 23, 2021
@marosset marosset deleted the win-vhd-publish-sku-exact-match branch February 23, 2021 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants