Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: deprecate aci-connector addon #4276

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR deprecates the "aci-connector" addon, which has long been unmaintained, and is based on an old version of virtual-kubelet.

virtual-kubelet integrations will work fine on Kubernetes + Azure clusters created w/ aks-engine, and we will leave it to the user to develop those integrations.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jackfrancis
Copy link
Member Author

cc @cpuguy83

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #4276 (37bc2e9) into master (b9c9dda) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4276      +/-   ##
==========================================
- Coverage   72.06%   72.02%   -0.04%     
==========================================
  Files         141      141              
  Lines       21686    21650      -36     
==========================================
- Hits        15628    15594      -34     
+ Misses       5107     5106       -1     
+ Partials      951      950       -1     
Impacted Files Coverage Δ
pkg/api/addons.go 98.05% <ø> (-0.05%) ⬇️
pkg/api/common/const.go 100.00% <ø> (ø)
pkg/api/converterfromapi.go 95.69% <ø> (-0.01%) ⬇️
pkg/api/convertertoapi.go 94.01% <ø> (-0.02%) ⬇️
pkg/api/defaults-custom-cloud-profile.go 85.12% <ø> (-0.13%) ⬇️
pkg/api/k8s_versions.go 100.00% <ø> (ø)
pkg/engine/artifacts.go 98.93% <ø> (-0.03%) ⬇️
pkg/engine/params_k8s.go 79.57% <ø> (-0.56%) ⬇️
pkg/engine/template_generator.go 68.20% <ø> (-0.15%) ⬇️
pkg/engine/templates_generated.go 43.17% <ø> (-0.25%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa3e15...3d3d88d. Read the comment docs.

cpuguy83
cpuguy83 previously approved these changes Feb 17, 2021
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acs-bot
Copy link

acs-bot commented Feb 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@acs-bot
Copy link

acs-bot commented Feb 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 6726888 into Azure:master Feb 19, 2021
@jackfrancis jackfrancis deleted the deprecate-virtual-kubelet branch February 19, 2021 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants