Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: remove addon-resizer from VHD #4269

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

The addon-resizer container image was pre-baked into the Linux VHDs for historical reasons, but is no longer a dependency of any aks-engine-provided Kubernetes components.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jackfrancis
Copy link
Member Author

cc @jadarsie

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #4269 (ed93655) into master (3497425) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4269   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files         141      141           
  Lines       21686    21686           
=======================================
  Hits        15630    15630           
  Misses       5106     5106           
  Partials      950      950           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3497425...ed93655. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 5aa3e15 into Azure:master Feb 19, 2021
@jackfrancis jackfrancis deleted the addon-resizer-rm branch February 19, 2021 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants