Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: expose custom image options as env vars #4244

Merged
merged 4 commits into from
Feb 9, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR enables the passing of the set of Kubernetes custom image values as env vars, so that custom image builds can be tested against any api model.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Feb 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #4244 (132aeb4) into master (661af28) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4244   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files         141      141           
  Lines       21702    21702           
=======================================
  Hits        15642    15642           
  Misses       5103     5103           
  Partials      957      957           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661af28...132aeb4. Read the comment docs.

@jackfrancis jackfrancis merged commit 84d5616 into Azure:master Feb 9, 2021
@jackfrancis jackfrancis deleted the e2e-custom-images branch February 9, 2021 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants