feat: deprecate flannel addon #4238
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4238 +/- ##
=======================================
Coverage 72.07% 72.08%
=======================================
Files 141 141
Lines 21702 21705 +3
=======================================
+ Hits 15642 15645 +3
Misses 5103 5103
Partials 957 957
Continue to review full report at Codecov.
|
pkg/api/vlabs/validate_test.go
Outdated
| err := p.OrchestratorProfile.KubernetesConfig.validateNetworkPlugin(false, false) | ||
| if plugin == NetworkPluginFlannel { | ||
| if err == nil { | ||
| t.Errorf("flannel should be not be allowed for new clusters") |
There was a problem hiding this comment.
Thanks for the English lesson :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
This PR officially deprecates the aks-engine-provided flannel addon implementation, which is several years old, and no longer supported.
Existing clusters (if there are any), will continue to execute
aks-engine upgradeandaks-engine scaletransitions.Issue Fixed:
Fixes #4230
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: