Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: configurable stability iterations timeout #4022

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR allows per-test configuartion of the "stability iterations" timeout value, and defaults to 5 seconds, which correlates with high watermark DNS lookup responses we want to be able to detect.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot acs-bot added the size/S label Nov 11, 2020
@acs-bot
Copy link

acs-bot commented Nov 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #4022 (bb3f10c) into master (404312a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4022   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         147      147           
  Lines       23164    23164           
=======================================
  Hits        17070    17070           
  Misses       4979     4979           
  Partials     1115     1115           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 48.97% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 404312a...bb3f10c. Read the comment docs.

@acs-bot acs-bot added size/M and removed size/S labels Nov 11, 2020
@jackfrancis jackfrancis merged commit e780eeb into Azure:master Nov 12, 2020
@jackfrancis jackfrancis deleted the e2e-stability-timeout-seconds branch November 12, 2020 01:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants