Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: set go sdk log level for Azure Stack clusters #3993

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

JesusAlvarezTorres
Copy link
Contributor

Reason for Change:

This change sets the go sdk log level to INFO for clusters in Azure Stack. Info level logs request information made to ARM by the cloud provider; the extra info is needed to correlate cloud provider operations with Azure Stack service logs when investigating issues in cloud provider.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot acs-bot added the size/S label Oct 30, 2020
@@ -19,6 +19,7 @@ spec:
env:
- name: AZURE_ENVIRONMENT_FILEPATH
value: "/etc/kubernetes/azurestackcloud.json"
<gosdkloglevel>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we simply include the configuration in here explicitly? We're already in a if azure stack scenario here.

cc @jadarsie

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, it should be fine to wrap it in a {{- if IsAzureStackCloud}} block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made suggested change, please take a look.

@acs-bot acs-bot added size/XS and removed size/S labels Nov 2, 2020
@jadarsie jadarsie changed the title chore: Set go sdk log level for Azure Stack clusters chore: set go sdk log level for Azure Stack clusters Nov 2, 2020
@jadarsie
Copy link
Member

jadarsie commented Nov 2, 2020

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #3993 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3993      +/-   ##
==========================================
- Coverage   73.83%   73.74%   -0.10%     
==========================================
  Files         147      147              
  Lines       23161    23161              
==========================================
- Hits        17102    17079      -23     
- Misses       4942     4970      +28     
+ Partials     1117     1112       -5     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 48.97% <ø> (ø)
cmd/get_skus.go 48.83% <0.00%> (-9.31%) ⬇️
cmd/root.go 61.82% <0.00%> (-8.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ce365...c6a12c7. Read the comment docs.

@jadarsie
Copy link
Member

jadarsie commented Nov 3, 2020

/lgtm

@acs-bot acs-bot added the lgtm label Nov 3, 2020
@jadarsie jadarsie merged commit 4262e4b into Azure:master Nov 3, 2020
@acs-bot
Copy link

acs-bot commented Nov 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jadarsie, JesusAlvarezTorres

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants