-
Notifications
You must be signed in to change notification settings - Fork 521
chore: set go sdk log level for Azure Stack clusters #3993
Conversation
@@ -19,6 +19,7 @@ spec: | |||
env: | |||
- name: AZURE_ENVIRONMENT_FILEPATH | |||
value: "/etc/kubernetes/azurestackcloud.json" | |||
<gosdkloglevel> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we simply include the configuration in here explicitly? We're already in a if azure stack scenario here.
cc @jadarsie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, it should be fine to wrap it in a {{- if IsAzureStackCloud}}
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made suggested change, please take a look.
fdbc836
to
c6a12c7
Compare
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #3993 +/- ##
==========================================
- Coverage 73.83% 73.74% -0.10%
==========================================
Files 147 147
Lines 23161 23161
==========================================
- Hits 17102 17079 -23
- Misses 4942 4970 +28
+ Partials 1117 1112 -5
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jadarsie, JesusAlvarezTorres The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
This change sets the go sdk log level to INFO for clusters in Azure Stack. Info level logs request information made to ARM by the cloud provider; the extra info is needed to correlate cloud provider operations with Azure Stack service logs when investigating issues in cloud provider.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: