-
Notifications
You must be signed in to change notification settings - Fork 521
refactor: remove unsupported orchestrators #3965
Conversation
cc @xuto2 |
7501121
to
c360b52
Compare
Codecov Report
@@ Coverage Diff @@
## master #3965 +/- ##
==========================================
- Coverage 73.72% 73.06% -0.66%
==========================================
Files 147 145 -2
Lines 23177 21856 -1321
==========================================
- Hits 17087 15969 -1118
+ Misses 4976 4849 -127
+ Partials 1114 1038 -76
Continue to review full report at Codecov.
|
c360b52
to
c151da4
Compare
I think we might be exceeding the custom data size limit with the 1_20_docker_e2e config: CI fails there consistently in this PR. |
c151da4
to
6e28a2c
Compare
6e28a2c
to
248d010
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Removes references to the Swarm, Swarm mode, Mesos, and DC/OS orchestrator types to simplify the AKS Engine codebase.
This code was already effectively dead, but was being retained out of an abundance of caution in order not to break AKS' vendoring needs. That is no longer a concern.
Issue Fixed:
Refs #2500
Credit Where Due:
Does this change contain code from or inspired by another project?
Requirements:
Notes:
Let me know if I should make separate PRs for each commit instead to make it more digestible.
There is further refactoring for simplicity that can be done here, probably starting with removal of
GenerateTemplate
and any remainingswitch
statements where the onlycase
is Kubernetes now. This seems like enough to review, however.