ci: add containerd PR E2E tests #3892
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3892 +/- ##
=======================================
Coverage 72.84% 72.84%
=======================================
Files 149 149
Lines 23213 23213
=======================================
Hits 16910 16910
Misses 5182 5182
Partials 1121 1121 Continue to review full report at Codecov.
|
jackfrancis
force-pushed
the
pr-e2e-containerd
branch
from
0440715 to
ac29386
Compare
jackfrancis
force-pushed
the
pr-e2e-containerd
branch
from
ac29386 to
2101709
Compare
| @@ -121,15 +121,6 @@ | |||
| "distro": "ubuntu-18.04-gen2", | |||
| "availabilityProfile": "VirtualMachineScaleSets", | |||
| "vnetSubnetId": "/subscriptions/SUB_ID/resourceGroups/RG_NAME/providers/Microsoft.Network/virtualNetworks/VNET_NAME/subnets/SUBNET_NAME" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I don't see any reason to include two Windows pools on the standard PR E2E config
| prop.WindowsProfile.ImageVersion == "" { | ||
| prop.WindowsProfile.WindowsPublisher = "microsoft-aks" | ||
| prop.WindowsProfile.WindowsOffer = "aks-windows" | ||
| prop.WindowsProfile.WindowsSku = "2019-datacenter-core-smalldisk-containerd-2005" |
There was a problem hiding this comment.
I'm torn between thinking we should publish containerd images monthly like we publish the docker images and not wanting to have to publish any more images to the marketplace than necessary...
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/azp run pr-e2e |
|
No pipelines are associated with this pull request. |
|
New changes are detected. LGTM label has been removed. |
|
/azp run pr-e2e |
|
No pipelines are associated with this pull request. |
|
/azp run pr-e2e |
|
No pipelines are associated with this pull request. |
|
/azp run pr-e2e |
|
No pipelines are associated with this pull request. |
|
/azp run pr-e2e |
|
No pipelines are associated with this pull request. |
Reason for Change:
This PR adds containerd configuration to the PR E2E jobs, so that we test containerd scenarios before merging changes.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: