This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: add ScaleCPULimitsToSandbox for hyperv runtimeclasses #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3889 +/- ##
=========================================
Coverage ? 72.83%
=========================================
Files ? 149
Lines ? 23203
Branches ? 0
=========================================
Hits ? 16900
Misses ? 5182
Partials ? 1121
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AbelHu
pushed a commit
that referenced
this pull request
Oct 9, 2020
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
Oct 10, 2020
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
Oct 23, 2020
AbelHu
added a commit
that referenced
this pull request
Oct 23, 2020
* feat: add ScaleCPULimitsToSandbox for hyperv runtimeclasses (#3889) * feat: Set default container runtime variables for AKS Windows 2004 Co-authored-by: Mark Rossetti <[email protected]>
penggu
pushed a commit
to penggu/aks-engine
that referenced
this pull request
Oct 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
On Windows kubelet computes CPU shares based on number of CPUs available on the host and passes that to the container runtime. When using Hyper-V isolated VMs the UVM the containers run in may have a different number of CPUs. Adding this flag instructs containerd to inspect the host and UVM CPU count and scale CPU limit values appropriately.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: