-
Notifications
You must be signed in to change notification settings - Fork 521
feat: allow custom containerd package for Linux nodes #3878
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3878 +/- ##
==========================================
+ Coverage 72.83% 72.84% +0.01%
==========================================
Files 149 149
Lines 23171 23211 +40
==========================================
+ Hits 16876 16908 +32
- Misses 5178 5182 +4
- Partials 1117 1121 +4
Continue to review full report at Codecov.
|
Do we have a stable URL we can add to |
@@ -8,6 +8,7 @@ | |||
"kubernetesConfig": { | |||
"networkPlugin": "azure", | |||
"containerRuntime": "containerd", | |||
"linuxContainerdURL": "https://moby.blob.core.windows.net/moby-containerd/moby-containerd/1.4.0+azure/bionic/linux_amd64/moby-containerd_1.4.0+azure-1_amd64.deb", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Can you also update |
Fixed. Also squashed all commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@chewong looks like the packer build is failing due to a var not getting replaced in the provisioning scripts.
|
Signed-off-by: Ernest Wong <[email protected]>
This looks great! One thing I'd add is an env var passthrough for |
Looks like cluster provisioning failed on 1.19 for some reason. |
Signed-off-by: Ernest Wong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @chewong! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chewong, jackfrancis, sozercan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ernest Wong [email protected]
Reason for Change:
Allow installation of custom containerd package on Linux nodes to increase e2e test coverage for ContainerD pipeline.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: