Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: create azure.json via CSE #3876

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Sep 28, 2020

Reason for Change:

This PR moves the initial creation of /etc/kubernetes/azure.json entirely to CSE. This is to ensure that OS images derived from a running Kubernetes node can be re-used to create new nodes.

tl;dr

  • CSE exits 0 immediately if it's already been run
  • We don't want cloud-init to blow away stuff that's been mutated by CSE (/etc/kubernetes/azure.json is created by CSE)

See #2849 for the initial implementation of "no azure.json" functionality.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #3876 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3876   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         149      149           
  Lines       23171    23173    +2     
=======================================
+ Hits        16876    16878    +2     
  Misses       5178     5178           
  Partials     1117     1117           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 48.65% <ø> (ø)
pkg/api/vlabs/validate.go 78.92% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190444d...cbdca0f. Read the comment docs.

@jackfrancis
Copy link
Member Author

cc @Michael-Sinz

@Michael-Sinz
Copy link
Collaborator

This fix makes it easier to build a "prototype model" type of VMSS scaling system which should really help scaling speed and reliability. (It was in building the prototype for the "prototype model" that we ran into this issue)

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Sep 29, 2020
@jackfrancis jackfrancis merged commit 1dd327a into Azure:master Sep 29, 2020
@jackfrancis jackfrancis deleted the azure-json-cse branch September 29, 2020 21:07
@acs-bot
Copy link

acs-bot commented Sep 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants