-
Notifications
You must be signed in to change notification settings - Fork 521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3876 +/- ##
=======================================
Coverage 72.83% 72.83%
=======================================
Files 149 149
Lines 23171 23173 +2
=======================================
+ Hits 16876 16878 +2
Misses 5178 5178
Partials 1117 1117
Continue to review full report at Codecov.
|
This fix makes it easier to build a "prototype model" type of VMSS scaling system which should really help scaling speed and reliability. (It was in building the prototype for the "prototype model" that we ran into this issue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
This PR moves the initial creation of
/etc/kubernetes/azure.json
entirely to CSE. This is to ensure that OS images derived from a running Kubernetes node can be re-used to create new nodes.tl;dr
/etc/kubernetes/azure.json
is created by CSE)See #2849 for the initial implementation of "no azure.json" functionality.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: