Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: fix Azure Stack E2E cluster provisioner #3874

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

haofan-ms
Copy link
Contributor

Reason for Change:

  • E2E test for kube-proxy version validation failed for k8s 1.15 as the hyperkube image for Azure Stack have a different suffix
  • E2E test for akse 0.48.0 upgrade scenario on Azure Stack hit certificate issue as python -v command didn't return the expected information for python 2

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #3874 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3874   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         149      149           
  Lines       23171    23173    +2     
=======================================
+ Hits        16876    16878    +2     
  Misses       5178     5178           
  Partials     1117     1117           
Impacted Files Coverage Δ
cmd/scale.go 12.63% <ø> (ø)
cmd/addpool.go 18.07% <100.00%> (ø)
cmd/deploy.go 60.59% <100.00%> (ø)
pkg/api/vlabs/validate.go 78.92% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1539189...bfb02b5. Read the comment docs.

@jadarsie jadarsie changed the title test: fixes for akse e2e tests on Azure Stack test: fix Azure Stack E2E cluster provisioner Sep 29, 2020
@jadarsie
Copy link
Member

lgtm

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Sep 29, 2020
@jackfrancis jackfrancis merged commit f13990b into Azure:master Sep 29, 2020
@acs-bot
Copy link

acs-bot commented Sep 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haofan-ms, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haofan-ms haofan-ms deleted the e2e-fix branch October 9, 2020 17:07
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants