Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: CLI operations #3837

Merged
merged 32 commits into from
Sep 25, 2020
Merged

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Sep 17, 2020

Reason for Change:

This PR thoroughly documents the CLI operations provided by AKS Engine.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Sep 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #3837 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3837   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         149      149           
  Lines       23171    23173    +2     
=======================================
+ Hits        16876    16878    +2     
  Misses       5178     5178           
  Partials     1117     1117           
Impacted Files Coverage Δ
cmd/scale.go 12.63% <ø> (ø)
cmd/addpool.go 18.07% <100.00%> (ø)
cmd/deploy.go 60.59% <100.00%> (ø)
pkg/api/vlabs/validate.go 78.92% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190444d...5df13cf. Read the comment docs.

@jackfrancis jackfrancis force-pushed the docs-cluster-operations branch from 5c40ead to 1f303b8 Compare September 25, 2020 16:34
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!

I couldn't find any major gaps or problems, so my comments are mostly typo corrections and optional suggestions.

docs/tutorials/cli-overview.md Outdated Show resolved Hide resolved
docs/tutorials/cli-overview.md Outdated Show resolved Hide resolved
docs/tutorials/cli-overview.md Outdated Show resolved Hide resolved
docs/tutorials/cli-overview.md Outdated Show resolved Hide resolved
docs/tutorials/cli-overview.md Outdated Show resolved Hide resolved
docs/topics/scale.md Outdated Show resolved Hide resolved
docs/topics/creating_new_clusters.md Outdated Show resolved Hide resolved
docs/topics/creating_new_clusters.md Outdated Show resolved Hide resolved
### Under the hood

During the upgrade, *aks-engine* successively visits virtual machines that constitute the cluster (first the master nodes, then the agent nodes) and performs the following operations:

Master nodes:
Control plane nodes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/topics/upgrade.md Outdated Show resolved Hide resolved
@jackfrancis jackfrancis merged commit 1539189 into Azure:master Sep 25, 2020
@jackfrancis jackfrancis deleted the docs-cluster-operations branch September 25, 2020 19:18
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants