Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: update VMSS node pools #3830

Merged
merged 11 commits into from
Sep 17, 2020
Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR introduces the new CLI feature aks-engine update --node-pool <node pool name> to update VMSS node pools on existing cluster via AKS Engine ARM template generation.

tl;dr With a new version of AKS Engine compared to the version used to build your cluster, and/or with changes to the agentPoolProfiles definition in the generated apimodel.json output, you use aks-engine update to essentially push a new VMSS model to your node pool. Subsequent scale out operations against that VMSS will therefore use the updated VMSS model.

Some real-world examples:

  • change the VM SKU
  • change the OS distro
  • change other AKS Engine-exposed OS configuration (e.g., sysctld)

In practice the implementation essentially re-uses aks-engine scale, giving that preëxisting command the right inputs to do an ARM template deployment against an existing VMSS with no change to the Count value.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #3830 into master will decrease coverage by 0.27%.
The diff coverage is 27.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3830      +/-   ##
==========================================
- Coverage   73.20%   72.92%   -0.28%     
==========================================
  Files         148      149       +1     
  Lines       25428    25579     +151     
==========================================
+ Hits        18614    18654      +40     
- Misses       5679     5789     +110     
- Partials     1135     1136       +1     
Impacted Files Coverage Δ
cmd/update.go 24.28% <24.28%> (ø)
cmd/scale.go 12.69% <44.44%> (+0.99%) ⬆️
cmd/root.go 60.52% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fb788...901cb75. Read the comment docs.

@jackfrancis
Copy link
Member Author

Worth mentioning: detailed documentation will follow this PR (as part of a larger set of improved documentation around all CLI functionality)

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me and should help users quite a bit.

We should update the aks-engine help example output in docs/community/developer-guide.md to include this command.

cmd/update.go Outdated Show resolved Hide resolved
jackfrancis and others added 2 commits September 16, 2020 16:26
fix error message stuttering

Co-authored-by: Matt Boersma <[email protected]>
@jackfrancis
Copy link
Member Author

This makes sense to me and should help users quite a bit.

We should update the aks-engine help example output in docs/community/developer-guide.md to include this command.

Done

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Sep 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 4f4b8e7 into Azure:master Sep 17, 2020
@jackfrancis jackfrancis deleted the aks-engine-update branch September 17, 2020 16:36
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants