-
Notifications
You must be signed in to change notification settings - Fork 521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3830 +/- ##
==========================================
- Coverage 73.20% 72.92% -0.28%
==========================================
Files 148 149 +1
Lines 25428 25579 +151
==========================================
+ Hits 18614 18654 +40
- Misses 5679 5789 +110
- Partials 1135 1136 +1
Continue to review full report at Codecov.
|
bde18ba
to
0b1544f
Compare
Worth mentioning: detailed documentation will follow this PR (as part of a larger set of improved documentation around all CLI functionality) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me and should help users quite a bit.
We should update the aks-engine help
example output in docs/community/developer-guide.md to include this command.
fix error message stuttering Co-authored-by: Matt Boersma <[email protected]>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
This PR introduces the new CLI feature
aks-engine update --node-pool <node pool name>
to update VMSS node pools on existing cluster via AKS Engine ARM template generation.tl;dr With a new version of AKS Engine compared to the version used to build your cluster, and/or with changes to the agentPoolProfiles definition in the generated
apimodel.json
output, you useaks-engine update
to essentially push a new VMSS model to your node pool. Subsequent scale out operations against that VMSS will therefore use the updated VMSS model.Some real-world examples:
In practice the implementation essentially re-uses
aks-engine scale
, giving that preëxisting command the right inputs to do an ARM template deployment against an existing VMSS with no change to theCount
value.Issue Fixed:
Requirements:
Notes: