This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR re-orders the "do I have the 'created by AKS VHD CI' OS signature?" and the "does my cluster configuration explicitly declare a VHD distro?" checks in order to enable AKS VHD re-use scenarios. E.g.:
Specifically, the boolean variable
FULL_INSTALL_REQUIRED
in our CSE implementation is functionally coupled with the VHD CI implementation that pairs with that CSE implementation at that commit of aks-engine. In practice, this means that for folks who want to re-use the AKS VHD as a base for creating their own Kubernetes node OS images can (1) take advantage of the optimized CSE code paths (e.g., don't execute unnecessaryapt
operations) and (2) implement the proper cleanup functionality so that the resultant Kubernetes node isn't unnecessarily burdened with the storage overhead of dozens of unused, pre-pulled Kubernetes hyperkube images (we use a common VHD to support a large set of Kubernetes versions).Issue Fixed:
Fixes #2036
Requirements:
Notes: