This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
test: disable 1.16 tests for various cluster configs #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed #2066 |
|
Filed #2067 |
|
Filed #2068 |
Codecov Report
@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
+ Coverage 76.69% 76.71% +0.01%
==========================================
Files 135 135
Lines 20587 20598 +11
==========================================
+ Hits 15790 15801 +11
Misses 3878 3878
Partials 919 919 |
|
Filed #2069 |
|
@saiyan86 to confirm that we have the correct logic for Azure NetworkPolicy addon on >= 1.16.0 clusters. |
|
lgtm |
jackfrancis
force-pushed
the
e2e-1.16-configs
branch
from
078ab90 to
4f2bff8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma, saiyan86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Several cluster configs are consistently failing in 1.16 tests. While we triage, let's disable them so that we can get more readable test signal for configurations that do work more consistently.
While triaging 1.16 breakage for Azure NetworkPolicy addon, I determined that the issue was not practical (i.e., the addon was installed correctly on the cluster) but rather that we were adding superfluous api model configuration for >= 1.16 for this addon, which was causing the E2E test runner to panic. Because the changes are in order to fix our test signal, I've included those changes in this PR.
Issue Fixed:
Fixes #2069
Requirements:
Notes: