This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
test: don’t timeout k8s resource deletes in E2E #2063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR addresses some observed flakes in E2E tests where resources take a long time to delete. This classification of error implemented by the
RunAndLogCommand
func doesn't make sense:Because, a "delete took too long to complete" error is not retry'able: the resource no longer exists to "re-delete"!
Issue Fixed:
Requirements:
Notes: