Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: don’t timeout k8s resource deletes in E2E #2063

Merged
merged 2 commits into from
Oct 1, 2019

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR addresses some observed flakes in E2E tests where resources take a long time to delete. This classification of error implemented by the RunAndLogCommand func doesn't make sense:

  1. If it wrapped by "retry a bunch of times" orchestration and
  2. If it implements a delete operation

Because, a "delete took too long to complete" error is not retry'able: the resource no longer exists to "re-delete"!

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #2063 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2063   +/-   ##
=======================================
  Coverage   76.67%   76.67%           
=======================================
  Files         135      135           
  Lines       20564    20564           
=======================================
  Hits        15768    15768           
  Misses       3877     3877           
  Partials      919      919

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Oct 1, 2019
@acs-bot acs-bot merged commit 2ac5f9c into Azure:master Oct 1, 2019
@acs-bot
Copy link

acs-bot commented Oct 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis deleted the e2e-kubectl-delete-no-timeout branch October 2, 2019 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants