This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: Skip installing docker if already installed on windows vhd #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjaini
changed the title
|
For this change we should introduce a new flag to indicate we want to run the CSE in a disconnected mode. If we take these changes as is we would skip installing the version of docker specified in the API model if any version is already installed. |
Codecov Report
@@ Coverage Diff @@
## master #2052 +/- ##
=======================================
Coverage 76.67% 76.67%
=======================================
Files 135 135
Lines 20564 20564
=======================================
Hits 15768 15768
Misses 3877 3877
Partials 919 919 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, rjaini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
For total disconnected case we don't want docker install flow to be trigger again when its already installed on windows vhd.
Issue Fixed:
Fixes #2051
Requirements:
Notes: