Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: Skip downloading of pause image if image already present in windows vhd #2040

Merged
merged 3 commits into from
Sep 30, 2019

Conversation

rjaini
Copy link
Contributor

@rjaini rjaini commented Sep 26, 2019

Reason for Change:

Skip downloading of pause image if image already present in windows vhd

Issue Fixed:

Fixes #2039

Requirements:

Notes:

@rjaini rjaini changed the title [WIP]: Skip pull of pause image if present in windows vhd [WIP]: Skip downloading of pause image if image already present in windows vhd Sep 26, 2019
@marosset
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #2040 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2040   +/-   ##
=======================================
  Coverage   76.67%   76.67%           
=======================================
  Files         135      135           
  Lines       20564    20564           
=======================================
  Hits        15768    15768           
  Misses       3877     3877           
  Partials      919      919

@rjaini rjaini changed the title [WIP]: Skip downloading of pause image if image already present in windows vhd feat: Skip downloading of pause image if image already present in windows vhd Sep 27, 2019
@rjaini rjaini requested a review from jadarsie September 27, 2019 22:23
@acs-bot acs-bot removed the lgtm label Sep 27, 2019
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Sep 30, 2019
@acs-bot acs-bot merged commit d181826 into Azure:master Sep 30, 2019
@acs-bot
Copy link

acs-bot commented Sep 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, rjaini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rjaini rjaini deleted the pushimage branch October 11, 2019 18:01
jackfrancis pushed a commit that referenced this pull request Oct 16, 2019
…dows vhd (#2040)

* image changes

* Add 1.16.0 in vhd prep

* fix the tagging issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip pull of pause image if present in windows vhd
3 participants