Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: enable azurestack telemetry for scale and upgrade scenarios #2001

Merged
merged 8 commits into from
Oct 1, 2019
Merged

feat: enable azurestack telemetry for scale and upgrade scenarios #2001

merged 8 commits into from
Oct 1, 2019

Conversation

deaborch
Copy link
Contributor

Reason for Change:

Configures a different Telemetry Tracking PID during scale, upgrade and deploy scenarios

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/M label Sep 20, 2019
@rjaini
Copy link
Contributor

rjaini commented Sep 20, 2019

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

cmd/scale.go Outdated Show resolved Hide resolved
@deaborch
Copy link
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2001 in repo Azure/aks-engine

@rjaini
Copy link
Contributor

rjaini commented Sep 25, 2019

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@fbbf5fa). Click here to learn what that means.
The diff coverage is 69.56%.

@@            Coverage Diff            @@
##             master    #2001   +/-   ##
=========================================
  Coverage          ?   76.67%           
=========================================
  Files             ?      135           
  Lines             ?    20578           
  Branches          ?        0           
=========================================
  Hits              ?    15778           
  Misses            ?     3881           
  Partials          ?      919

@acs-bot acs-bot added size/L and removed size/M labels Sep 26, 2019
@honcao
Copy link
Member

honcao commented Sep 26, 2019

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jackfrancis
jackfrancis previously approved these changes Sep 30, 2019
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/api/azenvtypes.go Outdated Show resolved Hide resolved
pkg/engine/deployment.go Outdated Show resolved Hide resolved
@acs-bot acs-bot removed the approved label Sep 30, 2019
cmd/scale.go Outdated Show resolved Hide resolved
cmd/upgrade.go Outdated Show resolved Hide resolved
pkg/api/azenvtypes.go Show resolved Hide resolved
pkg/api/defaults-custom-cloud-profile.go Outdated Show resolved Hide resolved
pkg/api/defaults-custom-cloud-profile.go Outdated Show resolved Hide resolved
pkg/api/defaults-custom-cloud-profile.go Outdated Show resolved Hide resolved
@rjaini
Copy link
Contributor

rjaini commented Sep 30, 2019

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rjaini
Copy link
Contributor

rjaini commented Sep 30, 2019

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a couple little items. Thank you, @deaborch!

cmd/upgrade.go Outdated Show resolved Hide resolved
pkg/api/defaults-custom-cloud-profile.go Outdated Show resolved Hide resolved
@rjaini
Copy link
Contributor

rjaini commented Sep 30, 2019

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rjaini
Copy link
Contributor

rjaini commented Sep 30, 2019

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@devigned
Copy link
Member

devigned commented Oct 1, 2019

lgtm

@devigned
Copy link
Member

devigned commented Oct 1, 2019

/lgtm

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acs-bot
Copy link

acs-bot commented Oct 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deaborch, devigned, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [devigned,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 966ac22 into Azure:master Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants