Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: run DNS validation against more than one query #1983

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

jackfrancis
Copy link
Member

Reason for Change:

We shouldn't test just one FQDN for DNS resolution during E2E

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #1983 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
- Coverage   76.71%   76.71%   -0.01%     
==========================================
  Files         135      135              
  Lines       20573    20557      -16     
==========================================
- Hits        15783    15770      -13     
+ Misses       3873     3871       -2     
+ Partials      917      916       -1

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Sep 19, 2019
@acs-bot acs-bot merged commit 26383d7 into Azure:master Sep 19, 2019
@acs-bot
Copy link

acs-bot commented Sep 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis deleted the e2e-dns-test branch October 2, 2019 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants