This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
update identity in vmss only once #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran 19 of 19 Specs in 4697.501 seconds
SUCCESS! -- 19 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAADPodIdentity (4697.43s)
PASS
ok github.com/Azure/aad-pod-identity/test/e2e 4697.501s |
kkmsft
reviewed
Sep 16, 2019
| @@ -96,6 +96,11 @@ func makeVMSSID(r azure.Resource) string { | |||
| return path.Join(r.SubscriptionID, r.ResourceGroup, r.ResourceName) | |||
| } | |||
|
|
|||
| func getVMSSName(vmssID string) string { | |||
| _, resourceName := path.Split(vmssID) | |||
There was a problem hiding this comment.
Is it possible to have an erroneous vmssID, if so how do we handle this ?
There was a problem hiding this comment.
If the vmssID is erroneous, then we fail while trying to create the client and not perform any operations.
There was a problem hiding this comment.
Can we please handle the error for the path.Split returning an empty string ?
kkmsft
reviewed
Sep 16, 2019
kkmsft
reviewed
Sep 16, 2019
kkmsft
reviewed
Sep 16, 2019
kkmsft
reviewed
Sep 16, 2019
kkmsft
reviewed
Sep 16, 2019
kkmsft
reviewed
Sep 16, 2019
kkmsft
reviewed
Sep 16, 2019
| wg.Add(1) | ||
| // node is no longer found in the cluster, all the assigned identities that were created in this sync loop | ||
| // and those that already exist for this node need to be deleted. | ||
| go c.cleanUpAllAssignedIdentitiesOnNode(nodeName, nodeTrackList, wg) |
There was a problem hiding this comment.
If we use anonymous function, we don't have to pass wg to cleanUpAllAssignedIdentitiesOnNode. Is that idiomatic way to use ?
There was a problem hiding this comment.
I'm passing the same wg for consolidating vmss node (which perform the cleanup if reqd) and update node deps. That way all our processing is done async.
kkmsft
reviewed
Sep 16, 2019
kkmsft
reviewed
Sep 16, 2019
aramase
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Update identity in vmss only once as identity is across all nodes in vmss and not just single node.
Issue Fixed:
Fixes #361
Notes for Reviewers: