Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Add resource limits and requests #372

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Add resource limits and requests #372

merged 2 commits into from
Sep 5, 2019

Conversation

kkmsft
Copy link
Contributor

@kkmsft kkmsft commented Sep 5, 2019

Reason for Change:

Add resource limits and requests.

Issue Fixed:

Fixes #187

Notes for Reviewers:

@kkmsft kkmsft requested a review from aramase September 5, 2019 06:33
aramase
aramase suggested changes Sep 5, 2019
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make the changes in deploy/noazurejson as well.

@kkmsft
Copy link
Contributor Author

kkmsft commented Sep 5, 2019

Thanks @aramase. Done and pushed.

aramase
aramase approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kkmsft kkmsft merged commit b02f76b into Azure:master Sep 5, 2019
@kkmsft kkmsft deleted the limits branch September 5, 2019 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aramase aramase aramase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CPU+Memory limits/requests to yaml
2 participants
@kkmsft @aramase