Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Remove dependency on azure.json #221

Merged
merged 4 commits into from
May 22, 2019
Merged

Remove dependency on azure.json #221

merged 4 commits into from
May 22, 2019

Conversation

feiyushi
Copy link
Contributor

As discussed in #204, aad-pod-identity is to use its own configuration to run mic. In this implementation, it uses a k8s secret to store the information that mic needs traditionally from the azure.json.

@kkmsft
Copy link
Contributor

kkmsft commented May 20, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kkmsft
Copy link
Contributor

kkmsft commented May 20, 2019

Thank you @feiyushi for this contribution. In general /lgtm from my side.

A few notes:

  • The understanding is that the docs for usage will come in as another PR.
  • For e2e, we will have to have another setting (via an env variable or so) to use the new deployment model and also have the setup steps in setup.sh(in the e2e directory) for setting up the secrets corresponding to this.

@kkmsft
Copy link
Contributor

kkmsft commented May 20, 2019

/cc @khenidak for a look since overall azure.json is tracked #204

@feiyushi feiyushi changed the title [WIP] Remove dependency on azure.json Remove dependency on azure.json May 20, 2019
@kkmsft kkmsft merged commit 57f3757 into Azure:master May 22, 2019
@kkmsft
Copy link
Contributor

kkmsft commented May 22, 2019

Thank you, @feiyushi. Merging this PR. We can do the doc and E2E test in the next PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants