Log binary versions #216
Log binary versions #216
Conversation
|
/azp run |
|
Commenter does not have sufficient privileges for PR 216 in repo Azure/aad-pod-identity |
| var MICVersion string | ||
|
|
||
| // NMIVersion is the version of the NMI component | ||
| var NMIVersion string | ||
|
|
||
| // PrintVersionAndExit prints the version and exits | ||
| func PrintVersionAndExit() { |
There was a problem hiding this comment.
Can this be used in case of -v command line option for both mmi and mic. Would be a good way to find out the comparable nmi/mic.
There was a problem hiding this comment.
do we really want to exit the process after printing the version?
There was a problem hiding this comment.
I was thinking if so if some one runs
nmi -v
or
mic -v
this is the only which needs to be called. In that case the exit can be left there as is - thoughts ?
Also wondering why the fmt was used here originally, does this assume that blog is not initialized or some other rule to be followed in version.go - any ideas ?
| flag.Parse() | ||
| if versionInfo { | ||
| version.PrintVersionAndExit() |
There was a problem hiding this comment.
is this what you meant @kkmsft ?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 216 in repo Azure/aad-pod-identity |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Acceptance criteria: As a user, I would like to see binary versions of NMI and MIC in the logs.
Fix a typo in the Makefile that caused the ARG for
NMI_VERSIONto be always empty. Add handling forMIC_VERSION.These versions will show in the logs next time we build an image using
NMI_VERSIONandMIC_VERSIONargs.Fixes #207