This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Reduce identity assignment time #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VMSS instances are not assigned again in a single sync cycle. This brings down the assignment times in sceanrios where a single node(in case of VMA) or instances from a single VMSS are assigned the same identity as result of different pods matching their bindings. Brings down the time take to assign identities in Azure#145.
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kkmsft
force-pushed
the
avoid_reassign_id
branch
from
9db2169
to
617d681
Compare
khenidak
approved these changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to ensure that identities already assigned to underlying VMs/VMSS instances are not assigned again in a single sync cycle. This brings down the assignment times in sceanrios where a single node(in case of VMA) or instances from a single VMSS are assigned the same identity as result of different pods matching their bindings. Brings down the time take to assign identities in #145.