This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Use go modules #179
Merged
Use go modules #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues with CI just using `go get` or having to fetch external tools (such as `dep`). The issue with ci using `go get` (without using go modules) is it fetches the master/HEAD from the upstream repo which can easily (and currently is) break.
|
ping @kkmsft CI is currently broken because |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with CI just using
go getor having to fetchexternal tools (such as
dep).The issue with ci using
go get(without using go modules) is itfetches the master/HEAD from the upstream repo which can easily (and
currently is) break.