This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Changed phase status filtering to work with init containers as well #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmsft
reviewed
Mar 8, 2019
kkmsft
reviewed
Mar 8, 2019
kkmsft
reviewed
Mar 8, 2019
| @@ -21,6 +22,9 @@ const ( | |||
| getPodListSleepTimeMilliseconds = 300 | |||
| ) | |||
|
@kkmsft ? any updates about this? can we merge it? |
|
@yarinm - Apologies for the delay. Initially I was hoping to get the e2e stabilized and then merge this. But that is going to take some time. Right now there is azure pipeline failure with this. I will fix that first and then get it merged this week. Thank you very much for this work. |
* Fix the file name for Azure pipeline file. * Add make build into separate script block. * Remove space from azure pipeline script * Remove space from azure pipeline script * Remove space from azure pipeline script * Remove circle ci configuration
|
@yarinm - can you please rebase your branch to the latest ? |
…d-pod-identity into init_container_support
|
I'm closing this PR, merge #191 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #169
Note that you can't use OR in selector interface but AND with NOT does work so i created an ignore list for statuses with don't want pod-identity to work on.