Static Anycast Gateway HLD

[superchild]

Static Anycast Gateway (SAG) HLD

Repo	PR title	State	Context
sonic-swss-common	[schema] Add SAG table for static anycast gateway
sonic-swss	[SAG]: Add SAG implementation
sonic-utilities	Add SAG implementation#1887 Add SAG implementation#2881
sonic-buildimage	Add SAG SONiC Yang
sonic-mgmt	Add static-anycast-gateway(SAG) test plan
sonic-mgmt	Add static-anycast-gateway(SAG) test cases

[ghost]

All CLA requirements met.

[liat-grozovik]

General comments:

• The HLD is missing a high level description before even discussing the config db which should be followed by yang model.
  Please check the HLD Template guidelines (https://github.com/Azure/SONiC/blob/master/doc/hld_template.md) it is very helpful to understand the feature and be able to review the code later on.
• The CLI as described is very high level and the part of the interface does not define and of the checkers expected on the CLI level. The CLI itself IMO should be described in the same way we have in the command reference md file.
• The flow is very high level and does to explain clearly (although there is a flow image). i don't see any reference to the SAI it self and the parameters used. Missing flow of vlan interface delete, not the sag part.
• The default behaviour should be clearly mentioned. it is disabled by default.
• It was mentioned it must go with VXLAN/EVPN. Is there any validation? what will happen if not? what tis the expected behaviour? ignored? error?

[superchild]

@kperumalbfn @venkatmahalingam @preetham-singh @hasan-brcm @dgsudharsan @liat-grozovik
All comments are replied and the HLD is updated.
Please help to check again.

[superchild]

All related PR's are sent and updated tracking table in this PR.
Please help to review it.

[zhangyanzhao]

@superchild would you please add the test PR into the code PR list? Thanks.

[superchild]

@superchild would you please add the test PR into the code PR list? Thanks.

@zhangyanzhao What is the test PR?
The unit test code is included in the following 3 PRs

• sonic-swss: [SAG]: Add SAG implementation sonic-swss#1974
• sonic-utilities: Add SAG implementation sonic-utilities#1887
• sonic-buildimage(yang model): Add SAG SONiC Yang sonic-buildimage#9018

sonic-swss-common#540 and sonic-utilities#1887 don't have reviewer yet, could you please assign someone help to review?

Thanks.

[zhangyanzhao]

Reviewers, can you please help to finish your review on this feature? Thanks.
@gord1306 @kperumalbfn @venkatmahalingam @preetham-singh @hasan-brcm

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: superchild / name: Jimi Chen (cd6941f, b0b5c10, ed64df7, 950267e, 63c7a3b, 3237e50, 5dbc369)

[liat-grozovik]

@superchild could you please sign the easyCLA?

[superchild]

@liat-grozovik thanks for your reminder, already signed.

[zhangyanzhao]

@liat-grozovik can you please let me know if we can merge this PR? Nvidia is the registered reviewer. Thanks.

[liat-grozovik]

It was reviewed by Nvidia and approved (@dgsudharsan and @Junchao-Mellanox ). please go a head and merge the HLD.
as for code PRs, need to see the review and feedback

[zhangyanzhao]

General comments:

• The HLD is missing a high level description before even discussing the config db which should be followed by yang model.
  Please check the HLD Template guidelines (https://github.com/Azure/SONiC/blob/master/doc/hld_template.md) it is very helpful to understand the feature and be able to review the code later on.
• The CLI as described is very high level and the part of the interface does not define and of the checkers expected on the CLI level. The CLI itself IMO should be described in the same way we have in the command reference md file.
• The flow is very high level and does to explain clearly (although there is a flow image). i don't see any reference to the SAI it self and the parameters used. Missing flow of vlan interface delete, not the sag part.
• The default behaviour should be clearly mentioned. it is disabled by default.
• It was mentioned it must go with VXLAN/EVPN. Is there any validation? what will happen if not? what tis the expected behaviour? ignored? error?

@superchild can you please address this comment? Thanks.

[zhangyanzhao]

HLD has been reviewed in SONiC community on 8/24/2021

[zhangyanzhao]

HLD was reviewed and approved by reviewers, merge the HLD.

[zhangyanzhao]

@liat-grozovik NVIDIA is the reviewing company, can you please merge this PR? Thanks.

[yanjundeng]

New Updated PRs:
sonic-swss : sonic-net/sonic-swss#3167
sonic-utility: sonic-net/sonic-utilities#3339
sonic-buildimage: sonic-net/sonic-buildimage#19069