Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: Issues with publishing logic using git diff #3943

Open
tyconsulting opened this issue Sep 8, 2023 · 2 comments
Open

[Bug Report]: Issues with publishing logic using git diff #3943

tyconsulting opened this issue Sep 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@tyconsulting
Copy link
Contributor

tyconsulting commented Sep 8, 2023

Describe the bug

the pipeline uses git diff to identify if there are files changed within a module and use this logic to identify if it should be published or ignored.

When the 1st attempt to publish failed for whatever reason. after failed attempt, if another unrelated update has merged into the branch, the Get-ModulesToPublish.ps1 script will detect nothing has changed for the module you had problem publishing initially, and you will not be able to publish it again without making any changes to the module, although the previous publishing attempt failed.

There should be an AlwaysPublish option so we can tell the pipeline to always publish, regardless if there are any changes to the module files between current and the previous commit.

cc @ahmadabdalla

To reproduce

  1. Update module A and commit it to main branch
  2. The module A pipeline kicks off automatically but failed (or manually stopped) so the module did not get published.
  3. Update module B and commit the change to main branch
  4. Manually run module A pipeline again because the previous run did not publish the module
  5. The 2nd attempt in module A pipeline skips the publishing because no changes are detected for module A

Code snippet

N/A

Relevant log output

N/A
@tyconsulting tyconsulting added the bug Something isn't working label Sep 8, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in Bug board Sep 8, 2023
@ahmadabdalla
Copy link
Contributor

Adding context: Just looking at a PR that was merged quite a while back that addresses something similar:
#2410 in response to #2153

@ahmadabdalla
Copy link
Contributor

Tagging #2896 for reference

@AlexanderSehr AlexanderSehr added this to the Azure Verfified Modules (AVM) - V3 milestone May 19, 2024
@AlexanderSehr AlexanderSehr removed this from the Azure Verfified Modules (AVM) - CI Issues milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Needs triage
Development

No branches or pull requests

3 participants