Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Allow blob public access for load generator storage accounts #1240

Open
heoelri opened this issue Jan 22, 2024 · 3 comments
Open

Disable Allow blob public access for load generator storage accounts #1240

heoelri opened this issue Jan 22, 2024 · 3 comments
Labels
enhancement New feature or request Security

Comments

@heoelri
Copy link
Contributor

heoelri commented Jan 22, 2024

A couple of storage accounts are getting flagged. This contains the global storage account where this is needed as it hosts images, but also the storage accounts used by the loadgenerator. Is this needed or can we disable public blob access for the loadgenerator storage accounts?

In-Scope All Storage Account types, except for File Storage.
Out-of-Scope File Storage Account types.
Logic If Allow Blob public access is disabled, then the control will pass.Note: ​​​​​​​This control will only be evaluated if the provisioning state is marked as 'Succeeded'.

@sebader thoughts?

@heoelri heoelri added enhancement New feature or request Security labels Jan 22, 2024
@sebader
Copy link
Member

sebader commented Jan 22, 2024

For the load generators I'm pretty sure that we can disable it without any issues

@sebader
Copy link
Member

sebader commented Jan 22, 2024

once this is merged, please redeploy the loadgenerator and lets make sure it runs

@heoelri
Copy link
Contributor Author

heoelri commented Jan 22, 2024

once this is merged, please redeploy the loadgenerator and lets make sure it runs

Yes, needed to check if INT completes successfully first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Security
Projects
None yet
Development

No branches or pull requests

2 participants