Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update ttl on reads for absolute expirations #16

Merged
merged 4 commits into from
Jan 4, 2020

Conversation

krispenner
Copy link
Contributor

@krispenner krispenner commented Dec 29, 2019

Only update cached item ttl on reads if sliding expiration was explicitly set in cache entry options.

Closes #15

@msftclas
Copy link

msftclas commented Dec 29, 2019

CLA assistant check
All CLA requirements met.

Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry on the changelog.md file in the Unreleased section, under the last item of the list, which points to your PR (like the one that is already there)

src/CosmosCache.cs Outdated Show resolved Hide resolved
@ealsur
Copy link
Member

ealsur commented Jan 3, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@ealsur ealsur self-assigned this Jan 3, 2020
@ealsur
Copy link
Member

ealsur commented Jan 3, 2020

I'll merge upon resolution of the open comment.

@ealsur ealsur merged commit 25df731 into Azure:master Jan 4, 2020
@ealsur
Copy link
Member

ealsur commented Jan 4, 2020

Thanks @krispenner !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ReplaceItem call optional
3 participants