Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm-res-compute-disk #652

Closed
2 tasks done
mbilalamjad opened this issue Feb 14, 2024 · 8 comments
Closed
2 tasks done

[Module Proposal]: avm-res-compute-disk #652

mbilalamjad opened this issue Feb 14, 2024 · 8 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Terraform 🌐 This is related to the Terraform IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@mbilalamjad
Copy link
Contributor

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-compute-disk

Module Details

Terraform equivalent of the Bicep module

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@mbilalamjad mbilalamjad added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Feb 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Feb 14, 2024
@mbilalamjad mbilalamjad moved this from Proposed to Looking for owners in AVM - Module Triage Feb 14, 2024
@fafriha
Copy link

fafriha commented Feb 21, 2024

@mbilalamjad I can take this one as I'm the compute SME in our team.

@mbilalamjad
Copy link
Contributor Author

Hi @fafriha,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@mbilalamjad mbilalamjad moved this from Looking for owners to Proposed in AVM - Module Triage Feb 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Feb 22, 2024
@mbilalamjad mbilalamjad added Status: Owners Identified 🤘 This module has its owners identified Status: In Triage 🔍 Picked up for triaging by an AVM core team member and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Needs: Triage 🔍 Maintainers need to triage still Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Feb 22, 2024
@fafriha
Copy link

fafriha commented Mar 4, 2024 via email

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Mar 4, 2024
@mbilalamjad
Copy link
Contributor Author

Hi @fafriha,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Mar 5, 2024
@mbilalamjad mbilalamjad added Class: Resource Module 📦 This is a resource module and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Mar 5, 2024
@mbilalamjad mbilalamjad moved this from Proposed to In development in AVM - Module Triage Mar 5, 2024

Important

@fafriha, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

Note

This message was posted as per ITA24.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Mar 26, 2024

Important

@fafriha, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

Note

This message was posted as per ITA24.

@terrymandin
Copy link

I will be taking ownership of this module.

@mbilalamjad mbilalamjad moved this from In development to In Review in AVM - Module Triage May 10, 2024
@Azure Azure deleted a comment from terrymandin May 25, 2024
@mbilalamjad mbilalamjad assigned terrymandin and unassigned fafriha May 29, 2024
@mbilalamjad mbilalamjad added Status: Module Available 🟢 The module is published and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Jun 3, 2024
@mbilalamjad mbilalamjad moved this from In Review to Done in AVM - Module Triage Jun 3, 2024
@terrymandin
Copy link

The AVM Review of this module has been completed and the module has been published to the registry. Requesting AVM team to close this module proposal and update module index accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Terraform 🌐 This is related to the Terraform IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Development

No branches or pull requests

3 participants