Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/res/resource-graph/query #307

Closed
2 tasks done
sebassem opened this issue Nov 16, 2023 · 9 comments
Closed
2 tasks done

[Module Proposal]: avm/res/resource-graph/query #307

sebassem opened this issue Nov 16, 2023 · 9 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@sebassem
Copy link
Contributor

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/resource-graph/query

Module Details

Submitting to help migrate from CARML

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

sebassem

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@sebassem sebassem added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Nov 16, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label Nov 16, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Nov 16, 2023
@matebarabas matebarabas changed the title [Module Proposal]: avm/res/resource-graph/query [Module Proposal]: avm/res/resource-graph/query Nov 16, 2023
@matebarabas matebarabas added the Status: In Triage 🔍 Picked up for triaging by an AVM core team member label Nov 16, 2023
@matebarabas
Copy link
Contributor

Hi @sebassem,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Nov 16, 2023
@sebassem
Copy link
Contributor Author

sebassem commented Nov 19, 2023 via email

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Nov 19, 2023
@matebarabas
Copy link
Contributor

Hi @sebassem,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

We just want to ask you to double check a few important things and take the next steps before you start the development.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - to name your module
    • TelemetryIdPrefix - to be used in your module's telemetry
  • For your module's repository:
    • Repository name and folder path are defined in RepoURL
    • Create the GitHub teams defined in the ModuleOwnersGHTeam and ModuleContributorsGHTeam columns and grant them permissions as described here.
      • In case of a Bicep module, please let the AVM core team know when you created these teams, and we'll help you with assigning the necessary permissions as described here.
      • In case of a Terraform module, follow the instructions here and assign the necessary permissions.

Grant the right level of permissions for the AVM core team and PG teams on your GitHub repo as described here.

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR if available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@matebarabas matebarabas moved this from Proposed to In development in AVM - Module Triage Nov 20, 2023
@matebarabas matebarabas added Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Class: Resource Module 📦 This is a resource module and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Nov 20, 2023
@matebarabas
Copy link
Contributor

Migrated from CARML by @sebassem - PR in review: Azure/bicep-registry-modules#657

@sebassem, for future modules, please leave a message in the comment section with a PR of your module and mention the person who helped with the initial triaging! Thanks!

@matebarabas matebarabas added the Status: In PR 👉 This is when an issue is due to be fixed in an open PR label Nov 20, 2023
@matebarabas
Copy link
Contributor

@sebassem, can you please create the related -owners- and -contributors GitHub teams, so we can close this issue? Please let me know when they're available, as I would then need to add them to the corresponding parent, which then you'll have to approve. Thanks!

@matebarabas matebarabas added Needs: Attention 👋 Reply has been added to issue, maintainer to review Status: Module Available 🟢 The module is published Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Status: In PR 👉 This is when an issue is due to be fixed in an open PR labels Nov 28, 2023
@sebassem
Copy link
Contributor Author

@sebassem, can you please create the related -owners- and -contributors GitHub teams, so we can close this issue? Please let me know when they're available, as I would then need to add them to the corresponding parent, which then you'll have to approve. Thanks!

Done

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Nov 28, 2023
@matebarabas
Copy link
Contributor

Thank you! I've just added both teams to the related parent. Please let me know when you accepted the request. Thanks!

@sebassem
Copy link
Contributor Author

Thank you! I've just added both teams to the related parent. Please let me know when you accepted the request. Thanks!

Just added them, is there anything else I need to do? Should I add my fork to those teams ?

@matebarabas
Copy link
Contributor

Thank you! No need to. These teams are to manage contributions on the BRM repository. E.g., if you ever decide to bring in more contributors or a secondary owner who can help you maintain this module.

With this, you have completed all necessary steps, so I'm closing this issue. Thank you again!

@github-project-automation github-project-automation bot moved this from In development to Done in AVM - Module Triage Nov 28, 2023
@matebarabas matebarabas removed the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Migrate from CARML 🚛 This item is related to a module migration from CARML Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Development

No branches or pull requests

2 participants