-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module Proposal]: avm-res-app-containerapp
(tf)
#266
Comments
I have a starter for this, based on AVM guidance, at this location: https://github.com/kewalaka/terraform-azurerm-avm-res-app-containerapp I'm using AZAPI because the purpose I've made this for requires workload profile support, which is Generally Available but not yet supported by the terraform azurerm provider. |
avm-res-app-containerapp
(tf)
Thank you @kewalaka for the module proposal, we will find a module owner and update accordingly |
Hi. I could take ownership of this module if nobody else on the team is able to. Thanks |
@PmeshramPM could you please advise if it's ok for Jared to take this or an owner from Apps solution area would be needed? |
@mbilalamjad - Yes, @jaredfholgate can take the ownership on this module. We can always have two owners. |
Hi @jaredfholgate, Thanks for requesting to be an AVM module owner! We just want to confirm you agree to the below pages that define what module ownership means: Any questions or clarifications needed, let us know! If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍): "I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER" Thanks, The AVM Core Team #RR
|
I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER |
Hi @jaredfholgate, Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities! We just want to ask you to double check a few important things and take the next steps before you start the development. Please use the following values explicitly as provided in the module index page:
Grant the right level of permissions for the AVM core team and PG teams on your GitHub repo as described here. You can now start the development of this module! ✅ Happy coding! 🎉 Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR if available. 🙏 Any further questions or clarifications needed, let us know! Thanks, The AVM Core Team
|
I see this hasn't yet been transferred to @lonegunmanb and @jiaweitao001 , can this be actioned please? I'm happy to support the work, however the official approach has blocking issues for me (relating to fixes required upstream in the AzureRM provider), so therefore for the time being I'm continuing this approach: https://github.com/kewalaka/terraform-azapi-res-app-containerapp This seeks to provide inputs & outputs that mirror azurerm, whilst using AzAPI internally. I note this isn't (quite) feature complete yet, and I realise it probably doesn't fit the desired approach, but sharing in case. |
Requested @jaredfholgate to share an update on this |
@jaredfholgate - Do you have an ETA for this? |
Hi @lonegunmanb is the owner of this module. I appreciate my name is still against it, this is due to an admin issue. |
Requesting @prjelesi to help transfer ownership to @lonegunmanb once he confirms. |
I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER |
Hi team, could you please provide an update? We are very interested in using this module. |
I'd like to migrate terraform-azure-container-apps to AVM, I hope I can finish this task in next week. |
@lonegunmanb When will this module be published? |
The initial review of this module is complete and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index. |
@lonegunmanb Thank you for your contribution. We will start testing. |
Important @lonegunmanb, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module. Tip To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label. |
Check for previous/existing GitHub issues/module proposals
Check this module doesn't already exist in the module indexes
Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-app-containerapp
Module Details
This is a module for a container apps resource.
This would be the Terraform version of the Bicep equivalent here: #128
kewalaka will work with jaredfholgate as an external contributor on this issue.
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
jaredfholgate
(Optional) Secondary Module Owner's GitHub Username (handle)
No Response
The text was updated successfully, but these errors were encountered: