Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm-res-app-containerapp (tf) #266

Closed
2 tasks done
kewalaka opened this issue Nov 5, 2023 · 31 comments · Fixed by #1239
Closed
2 tasks done

[Module Proposal]: avm-res-app-containerapp (tf) #266

kewalaka opened this issue Nov 5, 2023 · 31 comments · Fixed by #1239
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Terraform 🌐 This is related to the Terraform IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@kewalaka
Copy link
Contributor

kewalaka commented Nov 5, 2023

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-app-containerapp

Module Details

This is a module for a container apps resource.

This would be the Terraform version of the Bicep equivalent here: #128

kewalaka will work with jaredfholgate as an external contributor on this issue.

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

jaredfholgate

(Optional) Secondary Module Owner's GitHub Username (handle)

No Response

@kewalaka kewalaka added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Nov 5, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Nov 5, 2023
@kewalaka
Copy link
Contributor Author

kewalaka commented Nov 5, 2023

I have a starter for this, based on AVM guidance, at this location:

https://github.com/kewalaka/terraform-azurerm-avm-res-app-containerapp

I'm using AZAPI because the purpose I've made this for requires workload profile support, which is Generally Available but not yet supported by the terraform azurerm provider.

@mbilalamjad mbilalamjad added the Status: In Triage 🔍 Picked up for triaging by an AVM core team member label Nov 15, 2023
@mbilalamjad mbilalamjad changed the title [Module Proposal]: avm-res-app-containerapp Apps (res) (tf) [Module Proposal]: avm-res-app-containerapp (tf) Nov 15, 2023
@mbilalamjad
Copy link
Contributor

Thank you @kewalaka for the module proposal, we will find a module owner and update accordingly

@mbilalamjad mbilalamjad added the Class: Resource Module 📦 This is a resource module label Nov 15, 2023
@mbilalamjad mbilalamjad moved this from Proposed to Looking for owners in AVM - Module Triage Nov 15, 2023
@jaredfholgate
Copy link
Member

jaredfholgate commented Nov 18, 2023

Hi. I could take ownership of this module if nobody else on the team is able to. Thanks

@mbilalamjad
Copy link
Contributor

Hi. I could take ownership of this module if nobody else on the team is able to. Thanks

@PmeshramPM could you please advise if it's ok for Jared to take this or an owner from Apps solution area would be needed?

@PmeshramPM
Copy link
Contributor

@mbilalamjad - Yes, @jaredfholgate can take the ownership on this module. We can always have two owners.

@mbilalamjad
Copy link
Contributor

Hi @jaredfholgate,

Thanks for requesting to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Nov 20, 2023
@mbilalamjad mbilalamjad moved this from Looking for owners to Proposed in AVM - Module Triage Nov 20, 2023
@mbilalamjad mbilalamjad added Status: Owners Identified 🤘 This module has its owners identified and removed Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Nov 20, 2023
@jaredfholgate
Copy link
Member

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Nov 21, 2023
@mbilalamjad
Copy link
Contributor

Hi @jaredfholgate,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

We just want to ask you to double check a few important things and take the next steps before you start the development.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - to name your module
    • TelemetryIdPrefix - to be used in your module's telemetry
  • For your module's repository:
    • Repository name and folder path are defined in RepoURL
    • Create the GitHub teams defined in the ModuleOwnersGHTeam and ModuleContributorsGHTeam columns and grant them permissions as described here.
      • In case of a Bicep module, please let the AVM core team know when you created these teams, and we'll help you with assigning the necessary permissions as described here.
      • In case of a Terraform module, follow the instructions here and assign the necessary permissions.

Grant the right level of permissions for the AVM core team and PG teams on your GitHub repo as described here.

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR if available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@mbilalamjad mbilalamjad moved this from Proposed to In development in AVM - Module Triage Nov 22, 2023
@mbilalamjad mbilalamjad removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Nov 22, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Feb 3, 2024
@kewalaka
Copy link
Contributor Author

I see this hasn't yet been transferred to @lonegunmanb and @jiaweitao001 , can this be actioned please?

I'm happy to support the work, however the official approach has blocking issues for me (relating to fixes required upstream in the AzureRM provider), so therefore for the time being I'm continuing this approach:

https://github.com/kewalaka/terraform-azapi-res-app-containerapp

This seeks to provide inputs & outputs that mirror azurerm, whilst using AzAPI internally.

I note this isn't (quite) feature complete yet, and I realise it probably doesn't fit the desired approach, but sharing in case.

@mbilalamjad
Copy link
Contributor

Requested @jaredfholgate to share an update on this

@mbilalamjad mbilalamjad removed the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Mar 5, 2024
@v-xuto
Copy link
Member

v-xuto commented Mar 5, 2024

Related to issue: #261
CC: @jongio

@v-xuto
Copy link
Member

v-xuto commented Mar 26, 2024

@jaredfholgate - Do you have an ETA for this?

@jaredfholgate
Copy link
Member

@jaredfholgate - Do you have an ETA for this?

Hi @lonegunmanb is the owner of this module. I appreciate my name is still against it, this is due to an admin issue.

@mbilalamjad
Copy link
Contributor

Requesting @prjelesi to help transfer ownership to @lonegunmanb once he confirms.

@lonegunmanb
Copy link
Member

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Apr 17, 2024
@frandariem
Copy link

Hi team, could you please provide an update? We are very interested in using this module.

@lonegunmanb
Copy link
Member

I'd like to migrate terraform-azure-container-apps to AVM, I hope I can finish this task in next week.

@mbilalamjad mbilalamjad moved this from In development to In Review in AVM - Module Triage Jun 13, 2024
@v-xuto
Copy link
Member

v-xuto commented Jul 2, 2024

@lonegunmanb When will this module be published?

@lonegunmanb
Copy link
Member

The initial review of this module is complete and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index.

@lonegunmanb
Copy link
Member

@v-xuto @kewalaka This module is now available at here

@v-xuto
Copy link
Member

v-xuto commented Jul 4, 2024

@lonegunmanb Thank you for your contribution. We will start testing.

Important

@lonegunmanb, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@mbilalamjad mbilalamjad linked a pull request Jul 26, 2024 that will close this issue
6 tasks
@mbilalamjad mbilalamjad added Status: Module Available 🟢 The module is published and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Jul 26, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in AVM - Module Triage Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Terraform 🌐 This is related to the Terraform IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Development

Successfully merging a pull request may close this issue.

8 participants