Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zerofox/update alerts version #11610

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

zkto
Copy link
Contributor

@zkto zkto commented Dec 27, 2024

Required items, please complete

Change(s):

  • Version tag in alert data connector

Reason for Change(s):

  • In the last fix we didn't update the version, so its hard to know if the customers are running the latest version

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@zkto
Copy link
Contributor Author

zkto commented Dec 27, 2024

@microsoft-github-policy-service agree company="ZeroFox"

@v-prasadboke v-prasadboke self-assigned this Dec 30, 2024
@v-prasadboke v-prasadboke added Connector Connector specialty review needed Solution Solution specialty review needed labels Dec 30, 2024
@zkto zkto marked this pull request as ready for review December 30, 2024 15:40
@zkto zkto requested review from a team as code owners December 30, 2024 15:40
@DNRRomero
Copy link
Contributor

Hi @v-prasadboke , appreciate any comments you may have on this PR 😄

@v-prasadboke
Copy link
Contributor

In the last version 3.2.0, DNRRomeo already incremented the solution version. Therefore, there is no need to increment the content version of the Data connector.

https://github.com/Azure/Azure-Sentinel/pull/11189/files#diff-8453610b756b99feada60657d1cbc1ff7f39d310e739ec598315de040e21e8b5

If the customer environment has version 3.2.0, it means the latest fix has already been implemented.

@DNRRomero
Copy link
Contributor

@v-prasadboke Apparently customers are still confused about it as they can't find the solution version easily. In contrast, the connector version shows right away in the data-connectors section of Microsoft Sentinel

@zkto
Copy link
Contributor Author

zkto commented Jan 3, 2025

To be more clear, this is the version tag that we want to update

image
image

Version 1.0.0 vs Version 1.0.1

@DNRRomero
Copy link
Contributor

@v-prasadboke do you have any thoughts on this? is there another way for customers to see what version of our application they have installed?

@v-prasadboke v-prasadboke merged commit a885588 into Azure:master Jan 9, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants