-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove BOMs from analytics v2 #11261
Conversation
Hello @pemontto, I dont see much changes in the files |
It won't look like much as it's removing invisible byte order marks. They really shouldn't be in these files. See previous discussion - #1339 (comment) |
Hello @pemontto, I got it what you are trying to say here. But when a solution is getting packaged the packaging tool automatically resolve this issue. You can try it on your end by packaging a solution locally on your system |
I suggest you to please close on this PR |
We wanted to check on the status of PR #11261. PR is pending for more than 10+ days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation. |
Since we have not received a response in the last 7 days, we are closing your PR #11261 per our standard operating procedures. If you still need support for this issue, you can re-open the PR at any time. If you do re-open, we simply request that you ensure the PR has response to the last request. Thank you for your cooperation. |
This was previously discussed in #1339 but it seems like it's not yet handled in validations.
Change(s):
Reason for Change(s):
Version Updated: No, not required. This is a non-functional change and we'd expect to see the rule version pipeline fail.
Testing Completed: ✅