Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BOMs from analytics v2 #11261

Closed
wants to merge 2 commits into from
Closed

Remove BOMs from analytics v2 #11261

wants to merge 2 commits into from

Conversation

pemontto
Copy link
Contributor

@pemontto pemontto commented Oct 11, 2024

This was previously discussed in #1339 but it seems like it's not yet handled in validations.

Change(s):

Reason for Change(s):

  • consistency
  • prevent breaking pipelines

Version Updated: No, not required. This is a non-functional change and we'd expect to see the rule version pipeline fail.

Testing Completed: ✅

@pemontto pemontto requested review from a team as code owners October 11, 2024 08:26
@pemontto pemontto requested a review from a team as a code owner October 11, 2024 08:31
@v-atulyadav v-atulyadav added Solution Solution specialty review needed Detection Detection specialty review needed Analytic Rules labels Oct 11, 2024
@v-prasadboke
Copy link
Contributor

Hello @pemontto, I dont see much changes in the files

@pemontto
Copy link
Contributor Author

It won't look like much as it's removing invisible byte order marks. They really shouldn't be in these files. See previous discussion - #1339 (comment)

@v-prasadboke
Copy link
Contributor

v-prasadboke commented Nov 4, 2024

Hello @pemontto, I got it what you are trying to say here.

But when a solution is getting packaged the packaging tool automatically resolve this issue.

You can try it on your end by packaging a solution locally on your system
Please go through this documentation on how to use V3
https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md

@v-prasadboke
Copy link
Contributor

I suggest you to please close on this PR

@v-prasadboke
Copy link
Contributor

We wanted to check on the status of PR #11261. PR is pending for more than 10+ days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation.

@v-prasadboke
Copy link
Contributor

Since we have not received a response in the last 7 days, we are closing your PR #11261 per our standard operating procedures. If you still need support for this issue, you can re-open the PR at any time.

If you do re-open, we simply request that you ensure the PR has response to the last request. Thank you for your cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytic Rules Detection Detection specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants