Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure DevOps Extension: Azure AppConfiguration - Partial Complete #372

Closed
jkrusic19 opened this issue Jul 17, 2020 · 12 comments
Closed

Azure DevOps Extension: Azure AppConfiguration - Partial Complete #372

jkrusic19 opened this issue Jul 17, 2020 · 12 comments
Assignees
Labels
Azure Pipelines enhancement New feature or request

Comments

@jkrusic19
Copy link

Hello,

I would like to submit a feature request for the Azure DevOps extension "Azure AppConfiguration". When finding "keys that already exist, and we are going to overwrite" can we have the ability to suppress that warning so our pipelines look all "Green"?

Expected behavior:

  • With this specific step, this is expected behavior and do not see it as an issue.
@zhenlan
Copy link
Contributor

zhenlan commented Jul 17, 2020

@Yiming-Jia, not sure if there is a standard way in ADO to suppress warnings.

@Yiming-Jia
Copy link
Contributor

Hello @jkrusic19 ,

Yes, that should be a feature request to the Azure DevOps Pipeline. We use the pipeline task SDK to dump the message with warning log level and mark the task success with issues as the existing key-values overwritten, which is the way the task to notify user. And from Azure DevOps pipeline document, I saw it support the conditions which could let the follow task to continue to ran or canceled based on previous tasks' results.

@zhenlan zhenlan closed this as completed Aug 10, 2020
@zhenlan
Copy link
Contributor

zhenlan commented Sep 3, 2020

Reopen this issue as overwritten is expected in the configuration composition scenario and the warnings are annoying (false alarm).

@zhenlan zhenlan reopened this Sep 3, 2020
@mieel
Copy link

mieel commented Oct 12, 2020

imo this a bug and not a feature.

@TheHodge1234
Copy link

I agree this is a bug, there are other tasks which can "succeed" fully i.e. be green while supporting a warning in the task i.e. the Kubectl and Terraform tasks - there are warnings in the log, but the task completes successfully - this is the behaviour i would expect from the app configuration task.

image

@jimmyca15
Copy link
Member

@jkrusic19 I'd like to clarify the original ask a little. We do two things currently when we encounter overwritten keys. We write a warning and we set the pipeline's final state to "succeeded with issues" instead of "succeeded".

Is your request for us only to set the final state to "succeeded" rather than "succeeded with issues" or is it to omit the warning messages as well?

@TheHodge1234
Copy link

For my 2 cents it should set the final state to “succeeded” and the warning messages should be retained (like in my screenshot from the official Terraform extension)

@jimmyca15
Copy link
Member

Okay, that's what I'm leaning toward and want to make sure we are all on the same page.

@jkrusic19
Copy link
Author

Hello,

Yes success with warnings in the log output.

@crsbrns
Copy link

crsbrns commented Dec 2, 2020

Came here to make the same case, +1 for success with warnings in the log output

@MaryanneNjeri
Copy link
Contributor

A new release is out for the Azure App configuration -version 3.2.15, this issue has been addressed in the new release, the final state is set to "succeeded" and the warning messages are retained. In case you experience any issues please reach out. :)

@TheHodge1234
Copy link

I have tested and it works like a charm - thanks!

@zhenlan zhenlan added the enhancement New feature or request label Jan 5, 2021
@zhenlan zhenlan closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Pipelines enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants