Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] KEDA 2.15 and KEDA 2.14 introduces multiple breaking changes in AKS v1.30+ #4471

Closed
qpetraroia opened this issue Aug 12, 2024 · 8 comments
Assignees
Labels
KEDA For use of the KEDA addon for AKS stale Stale issue

Comments

@qpetraroia
Copy link
Contributor

qpetraroia commented Aug 12, 2024

AKS will be upgrading the KEDA addon to KEDA 2.15 on AKS clusters with K8s versions >=1.31. The AKS team has added KEDA 2.14 to AKS v1.30.

KEDA 2.15 and KEDA 2.14 will introduce multiple breaking changes. The breaking changes are listed below:

@qpetraroia qpetraroia added bug KEDA For use of the KEDA addon for AKS and removed bug labels Aug 12, 2024
@qpetraroia qpetraroia pinned this issue Aug 12, 2024
@qpetraroia qpetraroia changed the title [BREAKING CHANGE] KEDA 2.15 and KEDA 2.14 introduces multiple breaking changes in AKS v 1.30+ [BREAKING CHANGE] KEDA 2.15 and KEDA 2.14 introduces multiple breaking changes in AKS v1.30+ Aug 12, 2024
@ztoth123
Copy link

ztoth123 commented Aug 13, 2024

The impacted Azure Scaler is Azure Monitor instead of the other 2 as metricName is only used by that, right?
Where is it documented on https://keda.sh/?

@qpetraroia
Copy link
Contributor Author

qpetraroia commented Aug 14, 2024

Hi @ztoth123,

Nope! Azure Monitor is safe. This is because Azure Monitor's use of metricName refers to the Azure metric name, not the name for the HPA metric.

I have checked with the upstream KEDA maintainers and the only impacted Azure scalers are Azure Blob Scaler and Azure Log Analytics Scaler.

@ztoth123
Copy link

Thanks for the answer, I see now that the metricName is deprecated and it is mentioned e.g in this doc: https://keda.sh/docs/2.10/scalers/azure-log-analytics/
"metricName - Name to assign to the metric. (Optional, if not set KEDA will generate a name based on the workspaceId. DEPRECATED: This parameter is deprecated as of KEDA v2.10 and will be removed in version 2.12)"

@biefy biefy unpinned this issue Aug 14, 2024
@biefy biefy pinned this issue Aug 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the stale Stale issue label Sep 4, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity for 21 days. It will be closed if no further activity occurs within 7 days of this comment.

@qpetraroia qpetraroia removed the stale Stale issue label Sep 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the stale Stale issue label Sep 26, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity for 21 days. It will be closed if no further activity occurs within 7 days of this comment.

Copy link
Contributor

This issue will now be closed because it hasn't had any activity for 7 days after stale. qpetraroia feel free to comment again on the next 7 days to reopen or open a new issue after that time if you still have a question/issue or suggestion.

@miguelmq miguelmq unpinned this issue Oct 3, 2024
@qpetraroia qpetraroia reopened this Oct 10, 2024
@qpetraroia qpetraroia removed the stale Stale issue label Oct 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the stale Stale issue label Nov 1, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity for 21 days. It will be closed if no further activity occurs within 7 days of this comment.

Copy link
Contributor

This issue will now be closed because it hasn't had any activity for 7 days after stale. qpetraroia feel free to comment again on the next 7 days to reopen or open a new issue after that time if you still have a question/issue or suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KEDA For use of the KEDA addon for AKS stale Stale issue
Projects
None yet
Development

No branches or pull requests

2 participants