-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for mac catalyst with apple silicon. #1948
Comments
@kasimok Thanks for the report. https://aka.ms/csspeech/iosbinary xcframework package do contains support for both x86_64 and arm64 (ios-arm64_x86_64-maccatalyst). Anyways, I will try to reproduce your problem. |
Yes, I noticed the file's name contains both arm64 and x86_64, but somehow, it won't let me use that framework on arm64 Mac Catalyst. |
So far just verified that package contains required bits, not clear why you could not use it, so will be checking a bit more. To see what is bundled inside the binary you can check: % file MicrosoftCognitiveServicesSpeech MicrosoftCognitiveServicesSpeech: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64] MicrosoftCognitiveServicesSpeech (for architecture x86_64): Mach-O 64-bit dynamically linked shared library x86_64 MicrosoftCognitiveServicesSpeech (for architecture arm64): Mach-O 64-bit dynamically linked shared library arm64 |
@jhakulin could you please verify with your sample project, try adding catalysts support, can you run the Mac catalyst? I create this issue as my colleague who have a x86_64 runs OK. |
@jhakulin Hi Jarno, did you tried it? |
@kasimok I can repro the issue with the Swift sample you pointed out, thanks for the report. The issue might be related to pod installation. I will investigate that bit further. The reason I suspect something might be wrong with the pod installation is that I checked this sample https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/samples/objective-c/ios/speech-samples, it builds and that works ok for Mac Catalyst target on my Mac M1 (ARM based architecture). Possible workaround now for Mac Catalyst target is to add xcframework manually to Swift project, instead of using pod install |
@jhakulin I tried xcframework in the first place, the same behaviour. Our team does not use Below is the package file I use in swift package manager
|
@kasimok Yeah, not clear what is the reason yet. Note that Objective-C project works with the Macatalyst and same xcframework. I will investigate why Swift project does not. |
Oh, I just tried to create a bridging header and use it in swift project, now it works. So definitely there is a modulemap related bug here in the xcframework/cocoapods. |
@kasimok Thank you for sharing the workaround, indeed using bridging header provides alternative way to module import. I will look into module import issue. Internal workitem ref: 5276384 |
Potentially related issue: leetal/ios-cmake#172 We will continue investigating this, however at the moment there seems to be an external issue between CMAKE and Xcode generation with iOS toolchain to support properly Maccatalyst builds with Xcode. After those are solved, I am hopeful there would be better resolution to Maccatalyst module import issue. Using bridging header is recommended workaround at the moment. |
@jhakulin I knew it now, your "CMAKE and Xcode generation with iOS toolchain" must missed the modulemap file for mac catalyst platform. That's why we cannot use the symbols in swift directly. I tried, copy the modulemap, and the catalyst platform is OK. |
@kasimok Thank you for the information, I'll create a fix to next Speech SDK release. Thanks again! |
The fix will be in the 1.33.0 Speech SDK release, closing the issue. |
Describe the bug
I see catalyst is somehow supported, but not fully supported.
Run the sample on Mac Catalyst on x86 macOS works but on apple silicon it shows error of
No such module 'MicrosoftCognitiveServicesSpeech'
To Reproduce
Steps to reproduce the behavior:
Mac Catalyst
to the supported destinations for thespeech-sample
projectExpected behavior
fully support Mac Catalyst for both x86_64 and arm mac
Version of the Cognitive Services Speech SDK
1.28
Platform, Operating System, and Programming Language
Additional context
Why don't we support SPM directly?
The text was updated successfully, but these errors were encountered: