Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide PR preview with Netlify #82

Closed
tomkerkhove opened this issue Nov 25, 2019 · 6 comments
Closed

Provide PR preview with Netlify #82

tomkerkhove opened this issue Nov 25, 2019 · 6 comments

Comments

@tomkerkhove
Copy link
Contributor

Provide PR preview with Netlify to make sure that the pages are rendered correctly and can be deployed without noticing it on azug.be.

I can take this up if you want, if you install the "Netlify" GitHub app.

Example: tomkerkhove/promitor#766
@maartenba
Copy link
Member

Got the app URL? I see netlify logs but not sure that is it?

@tomkerkhove
Copy link
Contributor Author

App Url: https://github.com/apps/netlify

If you go to:
image

It routs you to https://deploy-preview-766--promitor-staging.netlify.com/

And I've added a nice preview banner on top:
image

@maartenba
Copy link
Member

Ok installed, build does seem to fail :-/

@tomkerkhove
Copy link
Contributor Author

tomkerkhove commented Nov 25, 2019 via email •
edited
Loading

@maartenba
Copy link
Member

Seems done?

@tomkerkhove
Copy link
Contributor Author

Jup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maartenba @tomkerkhove