Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BarycentricData instantiation time and unused code in secp curves #572

Merged
merged 6 commits into from
Jul 3, 2023
Merged

fix: BarycentricData instantiation time and unused code in secp curves #572

merged 6 commits into from
Jul 3, 2023

Conversation

codygunton
Copy link
Collaborator

@codygunton codygunton commented Jul 3, 2023 •
edited
Loading

Description

Using ClangBuildAnalyzer we identified some bottlenecks for compilation and found some fixes. The batch inversion at compilation time saves about 5 minutes of code generation! But we still have work to do (see #573).

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@codygunton codygunton mentioned this pull request Jul 3, 2023
Open
@codygunton codygunton changed the title fix: BarycentricData instantiation time + compilation profiling fix: BarycentricData instantiation time and unused code in secp curves Jul 3, 2023
@codygunton codygunton marked this pull request as ready for review July 3, 2023 16:20
@codygunton
Copy link
Collaborator Author

codygunton commented Jul 3, 2023 •
edited
Loading

@zac-williamson and I worked on this together, and it's small and uncontroversial, so we don't seek a review.

@codygunton codygunton merged commit bc78bb0 into master Jul 3, 2023
@codygunton codygunton deleted the cg/compilation-profiling-and-fixes branch July 3, 2023 16:27
@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@codygunton
fix: BarycentricData instantiation time and unused code in secp curves (
7856b03 
AztecProtocol/barretenberg#572)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@codygunton
fix: BarycentricData instantiation time and unused code in secp curves (
42ef955 
AztecProtocol/barretenberg#572)
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codygunton