Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Soundness issue in bigfield's evaluate_multiply_add method #558

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix: Soundness issue in bigfield's evaluate_multiply_add method #558

merged 2 commits into from
Jun 27, 2023

Conversation

Rumata888
Copy link
Contributor

@Rumata888 Rumata888 commented Jun 26, 2023 •
edited
Loading

Description

This pull request made it so that unsafe_evaluate_multiply_add became unconstrained for cases, where there was just 1 remainder. As in, the prime limb and basis limb constraints that bound the relation together were gone, making bigfield once again a nice ctf task.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Rumata888 Rumata888 changed the title Fixing bigfield yet again fix: soundness issue in bigfield evaluate_multiply_add Jun 26, 2023
@Rumata888 Rumata888 requested a review from zac-williamson June 26, 2023 17:57
@kevaundray kevaundray changed the title fix: soundness issue in bigfield evaluate_multiply_add fix: Soundness issue in bigfield's evaluate_multiply_add method Jun 26, 2023
@Rumata888 Rumata888 merged commit 1a98ac6 into master Jun 27, 2023
@Rumata888 Rumata888 deleted the is/bigfield_strikes_again branch June 27, 2023 12:47
@github-actions github-actions bot mentioned this pull request Jun 27, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@Rumata888
fix: Soundness issue in bigfield's evaluate_multiply_add method (Az…
016116f 
…tecProtocol/barretenberg#558)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@Rumata888
fix: Soundness issue in bigfield's evaluate_multiply_add method (Az…
5dff079 
…tecProtocol/barretenberg#558)
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zac-williamson zac-williamson zac-williamson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rumata888 @zac-williamson