Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adds VERSION file to release-please #542

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix: Adds VERSION file to release-please #542

merged 1 commit into from
Jun 16, 2023

Conversation

kevaundray
Copy link
Contributor

Description

This ensures that the VERSION file also gets updated. Asked @dbanks12 and he noted that it is needed for Circle CI and should probably be kept in sync with the version in the project() in CMakeLists.txt

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

dbanks12
dbanks12 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kevaundray kevaundray merged commit 31fb34c into master Jun 16, 2023
@kevaundray kevaundray deleted the kw/add-version-to-ci branch June 16, 2023 21:47
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@kevaundray
fix: Adds VERSION file to release-please (AztecProtocol/barretenber…
645781b 
…g#542)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@kevaundray
fix: Adds VERSION file to release-please (AztecProtocol/barretenber…
41042f1 
…g#542)
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevaundray @dbanks12