Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init_generator_data crashes when constants are changed #345

Closed
phated opened this issue Apr 12, 2023 · 2 comments
Closed

init_generator_data crashes when constants are changed #345

phated opened this issue Apr 12, 2023 · 2 comments

Comments

@phated
Copy link
Contributor

phated commented Apr 12, 2023

In #142, @suyash67 changed the constants for init_generator_data but when Noir consumed the changes, it caused tests to crash with the stack trace:

 thread #2, name = 'tests::noir_integration', stop reason = EXC_BAD_ACCESS (code=2, address=0x16fe00000)
  * frame #0: 0x00000001000ae52c prove_and_verify-5fafba34d1642f00`crypto::generators::init_generator_data() + 244
    frame #1: 0x00000001000b7814 prove_and_verify-5fafba34d1642f00`crypto::generators::get_g1_ladder(unsigned long) + 20
    frame #2: 0x000000010026d010 prove_and_verify-5fafba34d1642f00`acir_format::create_fixed_base_constraint(proof_system::plonk::UltraComposer&, acir_format::FixedBaseScalarMul const&) + 68
    frame #3: 0x000000010022a84c prove_and_verify-5fafba34d1642f00`acir_format::create_circuit(acir_format::acir_format const&, std::__1::unique_ptr<proof_system::ReferenceStringFactory, std::__1::default_delete<proof_system::ReferenceStringFactory> >&&) + 716
    frame #4: 0x000000010028bc54 prove_and_verify-5fafba34d1642f00`acir_proofs::get_total_circuit_size(unsigned char const*) + 164

We're reverting these value changes in #338 until the correct fix can be found and applied. This is the tracking issue for finding the core bug.

@suyash67
Copy link
Contributor

@phated @vezenovm Can you also please post the exact line at which its giving a bad memory access? I am thinking about this issue and it isn't possible to know the exact cause as I don't know how to run integration tests. Otherwise, can you tell me how can I run the failing test(s)?

@codygunton
Copy link
Collaborator

Closed by AztecProtocol/aztec-packages#2592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants