Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support nix package manager #234

Merged
merged 7 commits into from
Mar 14, 2023
Merged

feat: Support nix package manager #234

merged 7 commits into from
Mar 14, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Mar 9, 2023 •
edited
Loading

Description

Closes #233

This adds support for the Nix package manager and adds a GitHub Action to make sure the artifacts can be built.

Currently a draft because I'm trying to work through some difficulties with the Linux cross-compilation.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@phated phated requested a review from kobyhallx March 9, 2023 23:11
phated
phated commented Mar 9, 2023
View reviewed changes
.github/workflows/nix.yml Outdated Show resolved Hide resolved
phated
phated commented Mar 9, 2023
View reviewed changes
barretenberg.nix Outdated Show resolved Hide resolved
phated
phated commented Mar 9, 2023
View reviewed changes
barretenberg.nix Show resolved Hide resolved
@phated phated marked this pull request as ready for review March 13, 2023 15:18
kobyhallx
kobyhallx approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dbanks12
Copy link
Contributor

Looks mostly fine to me, but knowing nothing about Nix, I cannot follow the Nix files at all. Maybe some additional comments in those files would help newbies like me (and everyone else working on bberg)?

And It seems that the CircleCI checks are no longer tracked here in the PR since there is a github workflow. Is there some way to have it track both?

@phated
Copy link
Contributor Author

phated commented Mar 14, 2023

@dbanks12 the CircleCI runs are still done and shown. If you expand the "Show all checks" and scroll down you'll see the cci checks:
Screenshot 2023-03-14 at 8 29 53 AM

@kobyhallx kobyhallx merged commit 19a72fe into master Mar 14, 2023
@kobyhallx kobyhallx deleted the phated/nix branch March 14, 2023 15:36
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@phated
feat: Support nix package manager (AztecProtocol/barretenberg#234)
83f8450 
* feat: Support nix package manager & add github action to build nix artifacts

* Checking gnu flag for buildEnv override

* Need to be explicit about gcc11 for aarch64 linux

* Use runner.os name for artifacts

* Cleanup comments in nixfile

* Add concurrency group to workflow

* Update the cases when the workflow runs
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@phated
feat: Support nix package manager (AztecProtocol/barretenberg#234)
7f8e913 
* feat: Support nix package manager & add github action to build nix artifacts

* Checking gnu flag for buildEnv override

* Need to be explicit about gcc11 for aarch64 linux

* Use runner.os name for artifacts

* Cleanup comments in nixfile

* Add concurrency group to workflow

* Update the cases when the workflow runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobyhallx kobyhallx kobyhallx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Nix package manager
3 participants
@phated @dbanks12 @kobyhallx