From a5b4ec7b106f698a6b1fb7858b048b9b4a87f343 Mon Sep 17 00:00:00 2001
From: DanielKotov <159419107+DanielKotov@users.noreply.github.com>
Date: Mon, 2 Dec 2024 20:44:53 +0300
Subject: [PATCH] fix: witness changes in file sponge.hpp (#10345)

Static analyzer found that initial values in cache and state arrays
weren't properly constrained. Initially state fill in 0 + iv value, but
these values weren't constrained as witnesses.

We replaced witness_t constructor with function create_constant_witness
from class witness_t in file sponge.hpp.

All tests for poseidon2s passed after fix.
---
 .../barretenberg/stdlib/hash/poseidon2/sponge/sponge.hpp  | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/cpp/src/barretenberg/stdlib/hash/poseidon2/sponge/sponge.hpp b/cpp/src/barretenberg/stdlib/hash/poseidon2/sponge/sponge.hpp
index 6d79834aa..a812ec781 100644
--- a/cpp/src/barretenberg/stdlib/hash/poseidon2/sponge/sponge.hpp
+++ b/cpp/src/barretenberg/stdlib/hash/poseidon2/sponge/sponge.hpp
@@ -53,16 +53,16 @@ template <size_t rate, size_t capacity, size_t t, typename Permutation, typename
         : builder(&builder_)
     {
         for (size_t i = 0; i < rate; ++i) {
-            state[i] = witness_t<Builder>(builder, 0);
+            state[i] = witness_t<Builder>::create_constant_witness(builder, 0);
         }
-        state[rate] = witness_t<Builder>(builder, domain_iv.get_value());
+        state[rate] = witness_t<Builder>::create_constant_witness(builder, domain_iv.get_value());
     }
 
     std::array<field_t, rate> perform_duplex()
     {
         // zero-pad the cache
         for (size_t i = cache_size; i < rate; ++i) {
-            cache[i] = witness_t<Builder>(builder, 0);
+            cache[i] = witness_t<Builder>::create_constant_witness(builder, 0);
         }
         // add the cache into sponge state
         for (size_t i = 0; i < rate; ++i) {
@@ -122,7 +122,7 @@ template <size_t rate, size_t capacity, size_t t, typename Permutation, typename
             cache[i - 1] = cache[i];
         }
         cache_size -= 1;
-        cache[cache_size] = witness_t<Builder>(builder, 0);
+        cache[cache_size] = witness_t<Builder>::create_constant_witness(builder, 0);
         return result;
     }